Skip to content

chore: address commit comments for commit f6829da (issue: #5903) #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devshree-bhati
Copy link
Contributor

@devshree-bhati devshree-bhati commented Apr 21, 2025

Resolves #5903

Description

This PR addresses the comments of the core contributors to a previously done commit f6829da.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Apr 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 21, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/uniform/stdev $\color{green}184/184$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}184/184$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@devshree-bhati devshree-bhati changed the title Fix: address-commit-comments-f6829da Chore: address commit comments for commit f6829da () Apr 21, 2025
@devshree-bhati devshree-bhati changed the title Chore: address commit comments for commit f6829da () Chore: address commit comments for commit f6829da (issue: #5903) Apr 21, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 22, 2025
Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 22, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 22, 2025

PR Commit Message

chore: address commit comments for commit `f6829da` (issue: #5903)

PR-URL: https://github.com/stdlib-js/stdlib/pull/6769
Closes: https://github.com/stdlib-js/stdlib/issues/5903

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter changed the title Chore: address commit comments for commit f6829da (issue: #5903) chore: address commit comments for commit f6829da (issue: #5903) Apr 22, 2025
@Planeshifter Planeshifter merged commit 8948bbc into stdlib-js:develop Apr 22, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit f6829da)
3 participants