-
-
Notifications
You must be signed in to change notification settings - Fork 804
chore: address commit comments for commit f6829da
(issue: #5903)
#6769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address commit comments for commit f6829da
(issue: #5903)
#6769
Conversation
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*" If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
f6829da
()
f6829da
()f6829da
(issue: #5903)
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
f6829da
(issue: #5903)f6829da
(issue: #5903)
Resolves #5903
Description
This PR addresses the comments of the core contributors to a previously done commit f6829da.
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers