Skip to content

chore: add publish npm action #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 92 commits into from
Feb 25, 2025
Merged

chore: add publish npm action #217

merged 92 commits into from
Feb 25, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Feb 21, 2025

The publish action will be a bit different from biome's because we want to review our Releases as Drafts.

next steps:

  • replicate all the relevant /packages/@pglt/* folders
  • verify that downloading assets works
  • make sure we can publish prelease versions
  • once all that's done, we can publish to NPM

then head over to publishing for brew

Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! should we already update it to the correct names before merging or merge it now or keep it open until we have the input from supabase?

@juleswritescode juleswritescode marked this pull request as draft February 24, 2025 10:33
@juleswritescode
Copy link
Collaborator Author

@psteinroe this is not the most up-to-date version, I'll push that from my private branch later 👍
Regarding the name: I don't mind, we can also deploy to a different package name and delete it later. Shouldn't be a problem right now, I did that a couple of times on npm 👍

@juleswritescode juleswritescode marked this pull request as ready for review February 24, 2025 17:02
@juleswritescode
Copy link
Collaborator Author

@psteinroe Okay it's done! The package is now named pglt and the subpackages e.g. pglt-aarch64-linux.
It would be cool if you could double-check all the names and repository URLS – already it it twice, but I'm a bit tired
🤓

Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked the names and couldn't find any mismatch!

@psteinroe psteinroe merged commit 80a339a into main Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants