Full phase1 + phase2 CLI update #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Apr 2, 2025
porcellus
requested changes
Apr 11, 2025
| @@ -6,7 +6,7 @@ export let backendConfig = (): TypeInput => { | |||
| return { | |||
| supertokens: { | |||
| // this is the location of the SuperTokens core. | |||
| connectionURI: STConfig.supertokens.connectionURI, | |||
| connectionURI: (STConfig.supertokens as { connectionURI: string }).connectionURI, | |||
Comment on lines
+128
to
+130
| ContactMethodEmailOrPhone: plessmodels.ContactMethodEmailOrPhoneConfig{ | ||
| Enabled: true, | ||
| }, |
There was a problem hiding this comment.
this should be built like the flowtype above
| let template = ""; | ||
| const recipes = configToRecipes[configType].filter((recipe) => recipe !== "multiFactorAuth" && recipe !== "totp"); | ||
|
|
||
| const needsEmailVerification = false; |
There was a problem hiding this comment.
I don't think this is correct. (or it's unnecessary)
boilerplate/backend/shared/go/go.ts
Outdated
| userArguments?: UserFlags; | ||
| }): string => { | ||
| let template = ""; | ||
| const recipes = configToRecipes[configType].filter((recipe) => recipe !== "multiFactorAuth" && recipe !== "totp"); |
There was a problem hiding this comment.
Let's throw instead, if they requested MFA with go then it'll not work, it's better to fail than to generate a partial result.
| clientSecret: "${provider.clientSecret}", | ||
| ${ | ||
| provider.additionalConfig | ||
| ? `additionalConfig: ${JSON.stringify(provider.additionalConfig, null, 36)}` |
There was a problem hiding this comment.
Could we run the generated thing through a formatter? (e.g., prettier) We can add it to the backlog it's not necessary now.
| @@ -0,0 +1,35 @@ | |||
| import { type IndividualRecipe, type ConfigType } from "./types"; | |||
|
|
|||
| export const configToRecipes: Record<ConfigType, IndividualRecipe[]> = { | |||
Comment on lines
+304
to
+311
| if (hasMFA && isGoBackend) { | ||
| console.warn( | ||
| "\x1b[33m%s\x1b[0m", | ||
| "⚠️ Warning: Multi-factor authentication is not fully supported in the Go SDK yet. " + | ||
| "The generated app may not have full MFA functionality. " + | ||
| "Consider using a Node.js/Express backend for complete MFA support." | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'd prefer if this failed instead.
| emailPassword: | ||
| 'import EmailPassword from "supertokens-auth-react/recipe/emailpassword";\nimport { EmailPasswordPreBuiltUI } from "supertokens-auth-react/recipe/emailpassword/prebuiltui";', | ||
| thirdParty: | ||
| 'import ThirdParty, { Google, Github, Apple, Twitter } from "supertokens-auth-react/recipe/thirdparty";\nimport { ThirdPartyPreBuiltUI } from "supertokens-auth-react/recipe/thirdparty/prebuiltui";', |
There was a problem hiding this comment.
We could use ThirdParty.Google instead of importing Google directly. That way, we can drop unnecessary imports.
Comment on lines
+87
to
+98
| getGlobalClaimValidators: (input) => { | ||
| const emailVerificationClaimValidator = input.claimValidatorsAddedByOtherRecipes.find( | ||
| v => v.id === EmailVerification.EmailVerificationClaim.id | ||
| ); | ||
| if (emailVerificationClaimValidator) { | ||
| const filteredValidators = input.claimValidatorsAddedByOtherRecipes.filter( | ||
| v => v.id !== EmailVerification.EmailVerificationClaim.id | ||
| ); | ||
| return [...filteredValidators, emailVerificationClaimValidator]; | ||
| } | ||
| return input.claimValidatorsAddedByOtherRecipes; | ||
| } |
There was a problem hiding this comment.
I think we can/should drop this. If Mfa doesn't work without it, LMK and we'll fix it.
Comment on lines
+146
to
+148
| getRequiredSecondaryFactorsForUser: async () => { | ||
| return [${factorIds.join(", ")}]; | ||
| }, |
There was a problem hiding this comment.
We can drop this. It's not used by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Phase 1 and phase 2 changes, sans mutlitenancy for next, CLI flags and e2e test.