Skip to content

fix: add @types/node when adding drizzle #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brettearle
Copy link

closes: #509

Supersedes #536

Copy link

changeset-bot bot commented Apr 19, 2025

🦋 Changeset detected

Latest commit: 391ec69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brettearle
Copy link
Author

Hey @manuel3108 here is the PR to just add compatible node/types to the create. Did it on a clean branch and closed #536, can delete as well if needed

Copy link

pkg-pr-new bot commented Apr 19, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@539
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@539

commit: 391ec69

@manuel3108 manuel3108 changed the title Node types into create templates package.json in demo, minimal, library fix: add @types/node when adding drizzle Apr 19, 2025
@manuel3108
Copy link
Member

@AdrianGonz97 did a much better job at analyzing the actual problem here then I did. It's not necessary to add this package to everyone's installation, when it's only necessary in certain circumstances. I have updated this PR to reflect this, thanks for your help!

As for the storybook integration, I contacted one of the maintainers in #497, let's see where we can get from there on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add @types/node to npx sv create templates
2 participants