-
Notifications
You must be signed in to change notification settings - Fork 95
Use binary search for searching extent #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run clang-format -i
for consistent style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use git rebase -i
to squash the commits and read the article How to Write a Git Commit Message to refine the commit message.
simplefs_ext_search
e5fafce
to
0f9f20c
Compare
These are some bugs in this function. I dump the kernel message and it shows: By the information 0x46, we can find Another thing, you should also consider when the "end" is MAX_EXTENTS and ee_start != 0, this will also cause the same error. |
There were indeed some corner cases mentioned by @RoyWFHuang that was not handled. Thanks for the review. I've fixed the code and tried the CI test in my local environment, checked the output comes out as expected according to other CI test outputs from other pr. I think you can try out the github action workflow again. One additional question : should I rebase the branch again before the merge? |
Yes, please go ahead. |
e1e64db
to
71f7340
Compare
Finished rebasing. |
Thank @baekrang256 for contributing! |
No description provided.