Skip to content

Update cli to 1.7.1 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update cli to 1.7.1 #248

wants to merge 1 commit into from

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.virtuslab.scala-cli:cli from 1.5.4 to 1.7.1

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.virtuslab.scala-cli", artifactId = "cli" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.virtuslab.scala-cli", artifactId = "cli" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@typelevel-steward typelevel-steward bot mentioned this pull request Mar 18, 2025
@TonioGela TonioGela closed this Apr 20, 2025
@TonioGela TonioGela reopened this Apr 20, 2025
@TonioGela
Copy link
Member

TonioGela commented Apr 20, 2025

I'm still investigating on what's wrong here really.
What I can tell for sure is that:

  • the tests seem to be either hanging or not reporting the success status
  • locally both the 2.13 and the 3 submodules are testing successfully
  • This issue with native it's here since cli 1.6.0, but its release notes are not enlightening
  • The only section in 1.6.0 Release Notes that seems to be interesting is Cap vague Scala versions at defaults that might have introduced a change in how the Scala version gets resolved (and we fall in that case as we inject BuildInfo.scalaBinaryVersion rather than BuildInfo.scalaVersion) but overriding the scala version doesn't fix the issue and this won't explain in any case why it runs locally.
  • Something that changed between 1.5.7 and 1.6.0+ in the outputs seems to be when these lines are reported:
[info] Starting process '/home/runner/work/toolkit/toolkit/toolkit-test/native/target/scala-3.3.5/toolkit-test-test-out' on port '36951'.
[info] Starting process '/home/runner/work/toolkit/toolkit/toolkit/native/target/scala-3.3.5/toolkit-test-out' on port '33629'.
[info] Starting process '/home/runner/work/toolkit/toolkit/tests/native/target/scala-3.3.5/tests-test-out' on port '34225'.

Taking a look at builds using 1.5.4 (like the ones on main), these lines were "interspersed" with the rest of the output.
Can this indicate a different test reporting strategy that somehow the GH runner can't handle ? I'll masochistically try to run the action locally using act to see if I can get better intel on this, but I have an apple M series, so it won't be EXACTLY the same env.

Solving this is important as it will unlock all other PRs that do depend on the scala.js 1.18 bump.

@TonioGela TonioGela added the help wanted Extra attention is needed label Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant