Skip to content

Making FileUploadPropertyEditor more flexible #18336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

PeterKvayt
Copy link
Contributor

There is an existing issue for this PR: 18335

Copy link

github-actions bot commented Feb 13, 2025

Hi there @PeterKvayt, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @PeterKvayt,

Thanks for your PR to fix #18335, where you are making the FileUploadPropertyEditor more flexible.

One of the Core Collaborators team will review this as soon as possible - it also seems like one that we want HQ to review, so I'll contact them about it.

Best wishes

Emma

@emmagarland
Copy link
Contributor

Hi @PeterKvayt

I've chatted with HQ and we'll continue the discussion on your features & ideas post, #18335.

At that point, once a decision has been made, we can decide whether to progress, merge or close this PR.

Thanks again for your work

Emma

@AndyButland
Copy link
Contributor

Hi @PeterKvayt - I've been looking this afternoon to see if we could get this in for Umbraco 16. Unfortunately I had trouble re-targeting your branch, so took the liberty of recreating in a new one: #18942

Would it be OK to close this, and have you review what I've done just to make sure it works for your use case before we merge it in please? Happy also if you prefer to create your own new PR, but taken from and targeting v16/dev. Whichever you prefer. Thanks for the contribution and sorry it's taken a few weeks to progress it.

@PeterKvayt
Copy link
Contributor Author

Yes, we can close this pr due 18942

@PeterKvayt PeterKvayt closed this Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants