-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Making FileUploadPropertyEditor more flexible #18336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there @PeterKvayt, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @PeterKvayt, Thanks for your PR to fix #18335, where you are making the One of the Core Collaborators team will review this as soon as possible - it also seems like one that we want HQ to review, so I'll contact them about it. Best wishes Emma |
Hi @PeterKvayt I've chatted with HQ and we'll continue the discussion on your features & ideas post, #18335. At that point, once a decision has been made, we can decide whether to progress, merge or close this PR. Thanks again for your work Emma |
Hi @PeterKvayt - I've been looking this afternoon to see if we could get this in for Umbraco 16. Unfortunately I had trouble re-targeting your branch, so took the liberty of recreating in a new one: #18942 Would it be OK to close this, and have you review what I've done just to make sure it works for your use case before we merge it in please? Happy also if you prefer to create your own new PR, but taken from and targeting |
Yes, we can close this pr due 18942 |
There is an existing issue for this PR: 18335