-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Content Type inheritance #19034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v16/dev
Are you sure you want to change the base?
Content Type inheritance #19034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (4)
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/create/manifests.ts:13
- Ensure that the newly added entity type 'UMB_DOCUMENT_TYPE_ENTITY_TYPE' is consistently referenced throughout the application and that its naming reflects its intended purpose.
forEntityTypes: [
src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts:195
- Review the nullability of the 'asObservable' property to ensure that the observable is being correctly utilized when available.
(response as UmbRepositoryResponseWithAsObservable<DetailModelType>).asObservable?.(),
src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:345
- [nitpick] Double-check that casting the update payload to 'Partial' does not mask underlying type mismatches; consider addressing the root cause of the TypeScript complaints if possible.
this.#contentTypes.updateOne(toContentTypeUnique, { containers } as Partial<T>);
src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-property.element.ts:264
- Ensure that the parsed value from 'e.target.value' is a valid number; consider handling NaN cases explicitly to avoid unintended sortOrder values.
#onPropertyOrderChanged = (e: UUIInputEvent) => this.#partialUpdate({ sortOrder: parseInt(e.target.value as string) ?? 0 } as UmbPropertyTypeModel);
...I.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/observable-api/states/array-state.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-details.manager.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-details.manager.ts
Outdated
Show resolved
Hide resolved
...c/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts
Outdated
Show resolved
Hide resolved
...raco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts
Show resolved
Hide resolved
….com/umbraco/Umbraco-CMS into v16/feature/content-type-inheritance
Fixes #16510
Content Type Inheritance.