Skip to content

Content Type inheritance #19034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: v16/dev
Choose a base branch
from

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Apr 14, 2025

Fixes #16510

Content Type Inheritance.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review April 15, 2025 13:42
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 13:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/create/manifests.ts:13

  • Ensure that the newly added entity type 'UMB_DOCUMENT_TYPE_ENTITY_TYPE' is consistently referenced throughout the application and that its naming reflects its intended purpose.
forEntityTypes: [

src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts:195

  • Review the nullability of the 'asObservable' property to ensure that the observable is being correctly utilized when available.
(response as UmbRepositoryResponseWithAsObservable<DetailModelType>).asObservable?.(),

src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:345

  • [nitpick] Double-check that casting the update payload to 'Partial' does not mask underlying type mismatches; consider addressing the root cause of the TypeScript complaints if possible.
this.#contentTypes.updateOne(toContentTypeUnique, { containers } as Partial<T>);

src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-property.element.ts:264

  • Ensure that the parsed value from 'e.target.value' is a valid number; consider handling NaN cases explicitly to avoid unintended sortOrder values.
#onPropertyOrderChanged = (e: UUIInputEvent) => this.#partialUpdate({ sortOrder: parseInt(e.target.value as string) ?? 0 } as UmbPropertyTypeModel);

@umbraco umbraco deleted a comment from Copilot AI Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants