Fix selection on click in color area #1075
Open
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regression made in PR #1001 and metioned here: #1001 (comment)
Noticed in Chrome Version 135.0.7049.96 / Win 10 Pro.
In Chrome the click event returns
MouseEvent
, so it went toelse
statement and stopped executing theonMove()
event.It may be a bug that Firefox return
PointerEvent
as click is aMouseEvent
:https://stackoverflow.com/a/76900433
I can reproduce to issue in Firefox as well, so it may only be an issue click returning
PointerEvent
in older versions of Firefox and Safari as these has been resolved:https://bugzilla.mozilla.org/show_bug.cgi?id=1675847
https://bugs.webkit.org/show_bug.cgi?id=218665
However it is safe casting to
MouseEvent
asPointerEvent
inherits from this:https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist