feat: rolldown vite full bundle mode #107
Draft
+684
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
force-pushed
the
rolldown-vite-full-bundle-mode
branch
from
f46540b to
744fe8b
Compare
12 tasks
underfin
force-pushed
the
rolldown-vite-full-bundle-mode
branch
from
c580d0c to
191a670
Compare
commit: |
underfin
changed the title
underfin
commented
Apr 21, 2025
| '\t...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {},\n' + | ||
| '\tdefault: m\n' + | ||
| '})(__vite__cjsImport0_react)', | ||
| 'const react = ((m) => m?.__esModule ? m : { ...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {}, default: m })(__vite__cjsImport0_react)', |
There was a problem hiding this comment.
It is wired for it coudle be success at rolldown-vite branch.
There was a problem hiding this comment.
It's probably caused by the "vitest>vite" overrides. Vitest uses Vite to process the files and that changes the Function::toString result.
sapphi-red
reviewed
Apr 22, 2025
| function importModuleWithFullBundleMode() { | ||
| const importPromise = import(base + url) | ||
| return importPromise.then(() => | ||
| // @ts-expect-error globalThis.__rolldown_runtime__ |
There was a problem hiding this comment.
In the future, I think it's good to have the types exposed from rolldown so that we can use it like:
declare var __rolldown_runtime__: RolldownHmrRuntime| '\t...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {},\n' + | ||
| '\tdefault: m\n' + | ||
| '})(__vite__cjsImport0_react)', | ||
| 'const react = ((m) => m?.__esModule ? m : { ...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {}, default: m })(__vite__cjsImport0_react)', |
There was a problem hiding this comment.
It's probably caused by the "vitest>vite" overrides. Vitest uses Vite to process the files and that changes the Function::toString result.
Comment on lines
+222
to
+224
| if (!server.httpServer) { | ||
| throw new Error('HTTP server not available') | ||
| } |
There was a problem hiding this comment.
We should probably support middleware mode (it does not have server.httpServer) in the future.
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make dev build could be work. You could pass
npx vite --fullBundleModeatdefine/hmr-rootto see the initial build success and visit the url at browser.The HMR has issues, i will work for it at next.