refactor: remove vite-plugin-react-swc #382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we could still have 2 tests here and filter tests by plugin in the monorepo or you prefer testing both in 1 run? |
|
Ah, true. I'm fine with either. @ArnaudBarre do you have any preference? |
|
I don't have preferences. The plugins are quite similar and their test suites will re-use the same setups so from the eco-system ci I think one check is enough for all two/three plugins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vite-plugin-react-swc now lives in the vite-plugin-react monorepo.
cc @ArnaudBarre