feat: add support for rolldown-vite #451
Conversation
sapphi-red
added
p3-significant 🔨
| if ( | ||
| opts.jsxRuntime === 'classic' && | ||
| isJSX && | ||
| // OXC injects self and source so these plugins are not needed for rolldown-vite |
There was a problem hiding this comment.
Why is that? Does OXC run before Babel with rolldown-vite?
Technically it works without in default Vite but the source info is off which makes info in React devtools wrong (and breaks https://github.com/ArnaudBarre/vite-plugin-react-click-to-component)
There was a problem hiding this comment.
Oxc runs after this plugin and injects source and self. Oxc rejects an JSX with self and source with Duplicate __self prop found. error.
There was a problem hiding this comment.
In babel, the error only happens with automatic runtime. It looks like Oxc should align the behavior to that.
Would it be fine to add this change for now to unblock the error and revert it later?
There was a problem hiding this comment.
Ah, probably we should set development: false.
There was a problem hiding this comment.
Hmm, it seems it still errors with development: false.
There was a problem hiding this comment.
Made an issue: oxc-project/oxc#10391
There was a problem hiding this comment.
Ok I see. Yeah we can merge this as this is just a small DX issue
|
Can you add a line to the changelog? |
|
I added a changelog 👍 |
|
You will need to rebase for the changelog to not be in the beta version! |
Description
Moved the patch from https://github.com/vitejs/vite-ecosystem-ci/blob/rolldown-vite/README-temp.md.
This was tested with ecosystem-ci.