refactor(modulePreloadPolyfill): move polyfill code to own file #19737
+48
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
force-pushed
the
module-preload-polyfill
branch
from
da6f341 to
209caf2
Compare
privatenumber
force-pushed
the
module-preload-polyfill
branch
from
209caf2 to
3611035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor I encountered when working on a separate bug.
This PR refactors the module preload polyfill plugin by separating browser-specific code into its own file. The previous implementation used
anytypes, which reduced type safety.By moving the polyfill to a dedicated file with appropriate DOM type declarations, the code is now more stable and maintainable. This surfaced the following type error which I fixed: