perf: single chunk map #19757
Draft
perf: single chunk map #19757
+386
−381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
force-pushed
the
singular-chunk-map
branch
6 times, most recently
from
878f4d8 to
9ec1f7b
Compare
privatenumber
force-pushed
the
singular-chunk-map
branch
from
9ec1f7b to
827651c
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a PR against #19723, which should be merged first. Review this PR via privatenumber#2
Description
Previously, each chunk maintained its own registry mapping chunk paths to IDs for preloading, reducing string usage to save space. However, this registry was recreated for every chunk, even though a shared utility handled the actual preloading—which seemed like a more suitable place for this logic.
With this change, the chunk path-to-ID mapping is centralized in the shared preload method, eliminating repetitive chunk registries. I expect to see minor size improvements in apps that produce many chunks.