feat(create-vite): bump TS to 5.8 #19892
Open
+33
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sapphi-red
reviewed
Apr 18, 2025
| @@ -10,7 +10,8 @@ | |||
| /* Bundler mode */ | |||
| "moduleResolution": "bundler", | |||
| "allowImportingTsExtensions": true, | |||
| "isolatedModules": true, | |||
| "verbatimModuleSyntax": true, | |||
| "erasableSyntaxOnly": true, | |||
There was a problem hiding this comment.
I think this should be in the "Linting" section rather than "Bundler mode" section as it's not required for Vite. Maybe also good to add a comment that it can be disabled if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should encourage the use of the new erasableSyntaxOnly flag.
I've been using (verbatimModuleSyntax)[https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax] for quite a while but never changed it here. This flag makes import elision predictable and dead simple for transformers like esbuild. It implies isolatedModules.