fix(custom-element): ensure proper remount and prevent redundant slot parsing with shadowRoot false #13201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
edison1105
changed the title
edison1105
changed the title
edison1105
added
ready to merge
wolandec
reviewed
Apr 15, 2025
| @@ -1131,6 +1131,92 @@ describe('defineCustomElement', () => { | |||
| expect(target.innerHTML).toBe(`<span>default</span>`) | |||
| app.unmount() | |||
| }) | |||
|
|
|||
| test('toggle nested custom element with shadowRoot: false', async () => { | |||
There was a problem hiding this comment.
Hi @edison1105 , thanks for the fix, it works fine in our app as well!
I'm not sure if it is related to the current issue or I need to create a separate one, but If in custom element slot we have a v-if clause, then it never renders even if the clause is true, but if it's v-show - it works fine.
There was a problem hiding this comment.
Do you want me to add a test case to this branch or I can create an issue.
There was a problem hiding this comment.
please create new one, I will take a look later.
There was a problem hiding this comment.
Thank you so much for this @edison1105
The issue is created here #13206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13199