Skip to content

Initialize registry correctly for declarative shadow roots #11224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 16, 2025

Also finally turn this into a proper algorithm. The "Let registry" step and the next step are what's new.

Fixes #11219.


/parsing.html ( diff )

Also finally turn this into a proper algorithm. The "Let registry" step and the next step are what's new.

Fixes #11219.
@annevk annevk requested review from foolip and domenic April 16, 2025 08:57
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially seems reasonable but maybe @AtkinsSJ can confirm the logic.

@domenic domenic added topic: shadow Relates to shadow trees (as defined in DOM) topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: parser labels Apr 17, 2025
@annevk annevk merged commit 813c924 into main Apr 22, 2025
2 checks passed
@annevk annevk deleted the annevk/dsr branch April 22, 2025 12:37
@AtkinsSJ
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: parser topic: shadow Relates to shadow trees (as defined in DOM)
Development

Successfully merging this pull request may close these issues.

Undefined "registry" in parser "handle in head" state
3 participants