[cDAC] Handle non-mapped images correctly #114688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
max-charlamb
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
This was referenced Apr 15, 2025
max-charlamb
force-pushed
the
cdac-fix-loading
branch
from
aa14a2a to
469326c
Compare
Open
3 tasks
...ed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/EcmaMetadata_1.cs
Outdated
Show resolved
Hide resolved
mikem8361
approved these changes
Apr 16, 2025
...native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/TargetStream.cs
Outdated
Show resolved
Hide resolved
...native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/TargetStream.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
elinor-fung
approved these changes
Apr 16, 2025
...ed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/EcmaMetadata_1.cs
Outdated
Show resolved
Hide resolved
elinor-fung
reviewed
Apr 16, 2025
...ed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/EcmaMetadata_1.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Apr 18, 2025
...native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/TargetStream.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 18, 2025
mikem8361
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where cDAC could not load flat images correctly. Instead of using the RVA to find the correct section and offset, it would previously return the RVA of an unloaded image.
I went through an iteration where I parsed the RVAs manually depending on if the image was loaded, however I felt this was a lot of logic to have in the
Module : IData<Module>class. The newest revision utilizes the librariesPEReaderto fetch the module's metadata. In my view, the only issue with this current approach is some messiness around wrapping the Target in a Stream. Thesizedoesn't really make sense for this use case.See alternative fix: #114742
Tested on both loaded and unloaded images using
!clrma