-
Notifications
You must be signed in to change notification settings - Fork 5k
Convert genRuntimeEventSources to a C# source generator #114810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Convert genRuntimeEventSources to a C# source generator #114810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts a Python-based code generation script into a C# source generator to remove a direct Python dependency from our managed build.
- Converts the logic for manifest file processing and event method generation from Python to C#.
- Adopts Roslyn incremental generator APIs, new string interpolation with raw strings, and modern collection initialization.
Files not reviewed (5)
- eng/python.targets: Language not supported
- src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Language not supported
- src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj: Language not supported
- src/libraries/System.Private.CoreLib/gen/System.Private.CoreLib.Generators.csproj: Language not supported
- src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj: Language not supported
c1d8876
to
8a2bbb0
Compare
Nice! |
Convert this script to C# to remove the only direct python usage from within our managed build.
I primarily converted this script with VSCode's Copilot's Agent mode with ChatGPT 4.1, with a few logic adjustments as necessary to match the python script's codegen.