evmasm test case #16012
Open
evmasm test case #16012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
commented
Apr 19, 2025
Comment on lines
+96
to
+98
| // TODO: Enable when assembly import for EOF is implemented. | ||
| if (CommonOptions::get().eofVersion().has_value()) | ||
| m_shouldRun = false; |
There was a problem hiding this comment.
The test case can easily be extended support EOF, but we need to implement assembly import for EOF first.
This was referenced Apr 19, 2025
cameel
force-pushed
the
evmasm-test-case
branch
from
d712f7f to
1fd7f7d
Compare
cameel
force-pushed
the
evmasm-test-case
branch
from
1fd7f7d to
ce8ca0a
Compare
cameel
commented
Apr 19, 2025
Comment on lines
+70
to
+74
| if (!immediateArgument.starts_with("0x")) | ||
| BOOST_THROW_EXCEPTION(std::runtime_error(formatError("The immediate argument to PUSH must be a hex number prefixed with '0x'."))); | ||
|
|
||
| immediateArgument.remove_prefix("0x"s.size()); | ||
| codeJSON.push_back({{"name", "PUSH"}, {"value", immediateArgument}}); |
There was a problem hiding this comment.
It's quite annoying that the JSON format accepts only hex numbers here but without the 0x prefix. On the other hand for tag it accepts both both and the ones without 0x are actually decimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new custom test case that accepts EVM assembly as input, which allows inspecting the results of assembly import and evmasm optimizer. It should replace the Boost-based optimizer tests from
test/libevmasm/Optimiser.cppas well as the command-line tests for assembly import.The test case can take the assembly in JSON format as well as a simplified text format that can be easily post-processed into JSON ("plain assembly"). Plain assembly is currently very limited, but should still be enough to cover #15935. It allows using all opcodes as well as tags and jumps. It does not yet support subassemblies, data, metadata or the less common types of assembly items, but the format is designed to accommodate them and I'm going to add them in subsequent PRs.