fix: Not all console.error shows up in session replay play bar annotations #765
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ernestii
force-pushed
the
ernest/hdx-1457-bug-not-all-consoleerror-shows-up-in-session-replay-play-bar
branch
from
3a5abe8 to
0c4f782
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of missing console.errors in session replay playbar annotations by updating the event filters and error detection conditions.
- Updated the session subpanel filter to use allEventsFilter instead of filteredEventsFilter.
- Added a console check in the playbar error detection logic.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/SessionSubpanel.tsx | Replaced filteredEventsFilter with allEventsFilter for more inclusive event filtering. |
| packages/app/src/Playbar.tsx | Added an extra condition to detect events with component 'console' as errors. |
Files not reviewed (1)
- packages/app/styles/PlaybarSlider.module.scss: Language not supported
Comments suppressed due to low confidence (1)
packages/app/src/SessionSubpanel.tsx:368
- [nitpick] The rename from filteredEventsFilter to allEventsFilter may indicate a broader filtering intent; consider adding inline comments if the behavior change is not immediately clear from the naming alone.
allEventsFilter,
| @@ -75,6 +75,7 @@ export default function Playbar({ | |||
| const isError = | |||
| event.severity_text?.toLowerCase() === 'error' || | |||
| event.component === 'error' || | |||
| event.component === 'console' || | |||
There was a problem hiding this comment.
Double-check whether the comparison to 'console' should include a case normalization (similar to the toLowerCase call for severity_text) to ensure that all variations of console errors are captured.
| event.component === 'console' || | |
| event.component?.toLowerCase() === 'console' || |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -379,7 +379,7 @@ export default function SessionSubpanel({ | |||
| end, | |||
| whereLanguage, | |||
| searchedQuery, | |||
| filteredEventsFilter, | |||
| allEventsFilter, | |||
There was a problem hiding this comment.
@ernestii just curious here...what is filteredEventsFilter vs allEventsFilter and why does this work? Can you add a few comments for future devs?
No description provided.