Skip to content

fix: Not all console.error shows up in session replay play bar annotations #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix: Not all console.error shows up in session replay play bar annotations #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/app/src/Playbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export default function Playbar({
const isError =
event.severity_text?.toLowerCase() === 'error' ||
event.component === 'error' ||
event.component === 'console' ||
Copy link
Preview

Copilot AI Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check whether the comparison to 'console' should include a case normalization (similar to the toLowerCase call for severity_text) to ensure that all variations of console errors are captured.

Suggested change
event.component === 'console' ||
event.component?.toLowerCase() === 'console' ||

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

statusCode >= 399;

return {
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/SessionSubpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ export default function SessionSubpanel({
offset: 0,
},
filters: [
filteredEventsFilter,
allEventsFilter,
...(where ? [{ type: whereLanguage, condition: where }] : []),
],
}),
Expand All @@ -379,7 +379,7 @@ export default function SessionSubpanel({
end,
whereLanguage,
searchedQuery,
filteredEventsFilter,
allEventsFilter,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestii just curious here...what is filteredEventsFilter vs allEventsFilter and why does this work? Can you add a few comments for future devs?

where,
],
);
Expand Down
1 change: 1 addition & 0 deletions packages/app/styles/PlaybarSlider.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
height: 8px;
background-color: #333;
border-radius: 1px;
opacity: 0.5;

&:hover {
opacity: 1 !important;
Expand Down