Skip to content

CVE-2025-30204: bump github.com/golang-jwt/jwt/v4 to v4.5.2 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

CVE-2025-30204: bump github.com/golang-jwt/jwt/v4 to v4.5.2 #218

merged 2 commits into from
Apr 11, 2025

Conversation

sbiradar10
Copy link
Contributor

Is this a bug fix or adding new feature?
This PR fix CVE-2025-30204

What is this PR about? / Why do we need it?
Fixes CVE-2025-30204 by bumpinggithub.com/golang-jwt/jwt/v4 to v4.5.2.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 2, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 2, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sbiradar10!

It looks like this is your first PR to kubernetes-sigs/ibm-vpc-block-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ibm-vpc-block-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sbiradar10. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 2, 2025
@sbiradar10
Copy link
Contributor Author

/peer-review-needed

@dobsonj
Copy link
Member

dobsonj commented Apr 7, 2025

@sbiradar10 thanks a lot for the PR!
Can you also please bump secret-utils-lib in this PR?

go get github.com/IBM/[email protected]
go mod tidy && go mod vendor

We need that to bring in the fix from IBM/secret-utils-lib@afc2f3e which drops github.com/golang-jwt/[email protected]+incompatible from go.mod.

/label ok-to-test

@k8s-ci-robot
Copy link
Contributor

@dobsonj: The label(s) /label ok-to-test cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

@sbiradar10 thanks a lot for the PR!
Can you also please bump secret-utils-lib in this PR?

go get github.com/IBM/[email protected]
go mod tidy && go mod vendor

We need that to bring in the fix from IBM/secret-utils-lib@afc2f3e which drops github.com/golang-jwt/[email protected]+incompatible from go.mod.

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dobsonj
Copy link
Member

dobsonj commented Apr 7, 2025

/ok-to-test
/triage accepted
/priority important-soon
/sig storage
/kind bug

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2025
@sbiradar10
Copy link
Contributor Author

/retest-required

@dobsonj dobsonj mentioned this pull request Apr 8, 2025
Merged
@dobsonj
Copy link
Member

dobsonj commented Apr 8, 2025 •
edited
Loading

I opened #219 to fix the lint warnings. They definitely are not due to your changes, but unfortunately they will still block merges until they're fixed.

/lgtm
/assign @arahamad @ambiknai
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
sameshai
sameshai approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@sameshai sameshai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failure

arahamad
arahamad approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arahamad, sameshai, sbiradar10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@sameshai
Copy link
Contributor

/ok-to-test

@coveralls
Copy link

Coverage Status

coverage: 79.805%. remained the same
when pulling fe607ba on sbiradar10:CVE-2025-30204
into 971fb79 on kubernetes-sigs:master.

@k8s-ci-robot k8s-ci-robot merged commit 9cfa8cd into kubernetes-sigs:master Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameshai sameshai sameshai approved these changes

@arahamad arahamad arahamad approved these changes

@ambiknai ambiknai Awaiting requested review from ambiknai

Assignees

@dobsonj dobsonj

@ambiknai ambiknai

@arahamad arahamad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sbiradar10 @k8s-ci-robot @dobsonj @sameshai @coveralls @arahamad @ambiknai