fix golangci-lint v2.0.2 warnings #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
triage/accepted
dobsonj
force-pushed
the
fix-lint-warnings
branch
2 times, most recently
from
8922180 to
781cdbb
Compare
Signed-off-by: Jonathan Dobson <[email protected]>
dobsonj
force-pushed
the
fix-lint-warnings
branch
from
781cdbb to
3b3d855
Compare
sameshai
approved these changes
Apr 9, 2025
sameshai
approved these changes
Apr 11, 2025
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arahamad, dobsonj, sameshai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent PR's like #218 are blocked by the build job because golangci-lint v2.0.2 returns a series of new warnings. This PR aims to fix all of those lint warnings so the build job will complete successfully.
/triage accepted
/priority important-soon
/sig storage
/kind cleanup
/cc @sameshai @arahamad