-
Notifications
You must be signed in to change notification settings - Fork 2.7k
blockades: prevent direct changes to staging repos in kubernetes/k8s.io #34695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: sAchin-680 <[email protected]>
Welcome @sAchin-680! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sAchin-680 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sAchin-680. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: sAchin-680 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done as per your suggestion, replaced Go module import paths with actual GitHub repo names, and ensured client-go
and other existing staging repos have matching config. Let me know if anything else needs adjustment!
What type of PR is this?
/kind cleanup
/area prow
What this PR does / why we need it:
This PR introduces a new
blockades
rule to prevent direct modifications to thestaging/
directories in thekubernetes/k8s.io
repository.These staging repos are intended to be mirrored from upstream sources (e.g.,
kubernetes/kubernetes
), and changes should be made at the source instead. Blocking direct edits here helps maintain consistency, prevents configuration drift, and ensures changes follow the intended workflows.Special notes for your reviewer:
blockades
patterns defined inconfig.yaml
Does this PR introduce a user-facing change?