Skip to content

blockades: prevent direct changes to staging repos in kubernetes/k8s.io #34695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 143 additions & 61 deletions config/prow/plugins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -283,68 +283,150 @@ lgtm:
store_tree_hash: true

blockades:
- repos:
- kubernetes/kubernetes
blockregexps:
- ^examples/
explanation: "examples/ has moved to https://github.com/kubernetes/examples/"
- repos:
- kubernetes/kubernetes
blockregexps:
- ^pkg/util/[^/]+\.go$
explanation: "Utility code must be added to a subpackage like pkg/util/flag, not pkg/util directly. See: #49923"
- repos:
- kubernetes/kubernetes
blockregexps:
- ^test/conformance/testdata/conformance.yaml$
branchregexp: "^release-*"
explanation: "`test/conformance/testdata/conformance.yaml` cannot be updated on release branches."
- repos:
- kubernetes/community
blockregexps:
- ^events/2016
- ^events/2017
- ^events/2018
- ^events/elections/2017
- ^events/elections/2018
- ^events/elections/2019
explanation: "These files are historical, and from events that have already occurred."
- repos:
- kubernetes/community
blockregexps:
- ^keps/
explanation: "KEPs have been relocated to [kubernetes/enhancements](https://git.k8s.io/enhancements/)! Please submit any updates there."
- repos:
- kubernetes/community
blockregexps:
- ^contributors/design-proposals/
explanation: "The Design Proposal process has been deprecated in favor of [Kubernetes Enhancement Proposals (KEP)](https://git.k8s.io/enhancements/). These documents are here for historical purposes only."
- repos:
- kubernetes/enhancements
blockregexps:
- ^keps/NEXT_KEP_NUMBER$
explanation: "KEP numbers are obsolete. Please remove any changes to `NEXT_KEP_NUMBER` from this PR and ensure the KEP filename is the draft date and KEP title e.g., `YYYYMMDD-pony-controller.md`"
- repos:
- kubernetes/release
blockregexps:
- ^push-build.sh
explanation: "Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins."
- repos:
- kubernetes/client-go
blockregexps:
- .*
explanation: "We do not accept changes directly against this repository. Please see `CONTRIBUTING.md` for information on where and how to contribute instead."
- repos:
- kubernetes/k8s.io
blockregexps:
- ^k8s.gcr.io/
explanation: "k8s.gcr.io Image registry is frozen from April 2023. Please update the manifests in registry.k8s.io folder instead"
- repos:
- kubernetes/cri-api
blockregexps:
- .*
explanation: "We do not accept changes directly against this repository. Please see `CONTRIBUTING.md` for information on where and how to contribute instead."
- repos:
- kubernetes/api
- kubernetes/apiextensions-apiserver
- kubernetes/apimachinery
- kubernetes/apiserver
- kubernetes/cli-runtime
- kubernetes/client-go
- kubernetes/cloud-provider
- kubernetes/cluster-bootstrap
- kubernetes/code-generator
- kubernetes/component-base
- kubernetes/component-helpers
- kubernetes/controller-manager
- kubernetes/cri-api
- kubernetes/cri-client
- kubernetes/csi-translation-lib
- kubernetes/dynamic-resource-allocation
- kubernetes/endpointslice
- kubernetes/externaljwt
- kubernetes/kms
- kubernetes/kube-aggregator
- kubernetes/kube-controller-manager
- kubernetes/kube-proxy
- kubernetes/kube-scheduler
- kubernetes/kubectl
- kubernetes/kubelet
- kubernetes/metrics
- kubernetes/mount-utils
- kubernetes/pod-security-admission
- kubernetes/sample-apiserver
- kubernetes/sample-cli-plugin
- kubernetes/sample-controller
required_labels:
- do-not-merge
missing_label_policy:
org: kubernetes
repo:
- api
- apiextensions-apiserver
- apimachinery
- apiserver
- cli-runtime
- client-go
- cloud-provider
- cluster-bootstrap
- code-generator
- component-base
- component-helpers
- controller-manager
- cri-api
- cri-client
- csi-translation-lib
- dynamic-resource-allocation
- endpointslice
- externaljwt
- kms
- kube-aggregator
- kube-controller-manager
- kube-proxy
- kube-scheduler
- kubectl
- kubelet
- metrics
- mount-utils
- pod-security-admission
- sample-apiserver
- sample-cli-plugin
- sample-controller
label: do-not-merge
label: do-not-merge
comment: |
This is a staging repository. Please submit your PR to https://github.com/kubernetes/kubernetes instead.

- repos:
- kubernetes/kubernetes
blockregexps:
- ^examples/
explanation: "examples/ has moved to https://github.com/kubernetes/examples/"

- repos:
- kubernetes/kubernetes
blockregexps:
- ^pkg/util/[^/]+\.go$
explanation: "Utility code must be added to a subpackage like pkg/util/flag, not pkg/util directly. See: #49923"

- repos:
- kubernetes/kubernetes
blockregexps:
- ^test/conformance/testdata/conformance.yaml$
branchregexp: "^release-*"
explanation: "`test/conformance/testdata/conformance.yaml` cannot be updated on release branches."

- repos:
- kubernetes/community
blockregexps:
- ^events/2016
- ^events/2017
- ^events/2018
- ^events/elections/2017
- ^events/elections/2018
- ^events/elections/2019
explanation: "These files are historical, and from events that have already occurred."

- repos:
- kubernetes/community
blockregexps:
- ^keps/
explanation: "KEPs have been relocated to [kubernetes/enhancements](https://git.k8s.io/enhancements/)! Please submit any updates there."

- repos:
- kubernetes/community
blockregexps:
- ^contributors/design-proposals/
explanation: "The Design Proposal process has been deprecated in favor of [Kubernetes Enhancement Proposals (KEP)](https://git.k8s.io/enhancements/). These documents are here for historical purposes only."

- repos:
- kubernetes/enhancements
blockregexps:
- ^keps/NEXT_KEP_NUMBER$
explanation: "KEP numbers are obsolete. Please remove any changes to `NEXT_KEP_NUMBER` from this PR and ensure the KEP filename is the draft date and KEP title e.g., `YYYYMMDD-pony-controller.md`"

- repos:
- kubernetes/release
blockregexps:
- ^push-build.sh
explanation: "Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins."

- repos:
- kubernetes/client-go
blockregexps:
- .*
explanation: "We do not accept changes directly against this repository. Please see `CONTRIBUTING.md` for information on where and how to contribute instead."

- repos:
- kubernetes/k8s.io
blockregexps:
- ^k8s.gcr.io/
explanation: "k8s.gcr.io Image registry is frozen from April 2023. Please update the manifests in registry.k8s.io folder instead."

- repos:
- kubernetes/cri-api
blockregexps:
- .*
explanation: "We do not accept changes directly against this repository. Please see `CONTRIBUTING.md` for information on where and how to contribute instead."
blunderbuss:
max_request_count: 2
use_status_availability: true
Expand Down