8340344: The first item in TreeView is not aligned in the beginning #1715
Conversation
|
👋 Welcome back Ziad-Mid! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| @@ -207,7 +207,7 @@ public final DoubleProperty indentProperty() { | |||
| boolean disclosureVisible = disclosureNode != null && treeItem != null && ! treeItem.isLeaf(); | |||
|
|
|||
| final double defaultDisclosureWidth = maxDisclosureWidthMap.containsKey(tree) ? | |||
| maxDisclosureWidthMap.get(tree) : 18; // JDK-8119169: default width of default disclosure node | |||
| maxDisclosureWidthMap.get(tree) : 20; // JDK-8119169: default width of default disclosure node | |||
There was a problem hiding this comment.
This is probably not a good solution: I think the root cause is not in that the default value is incorrect, but in that two different values are used in the same view (i.e. that it first uses the default value, then the value computed from the disclosure node, if I read the code correctly).
Could you please investigate?
I've linked the JBS ticket mentioned in the comment, take a look at the discussion there https://bugs.openjdk.org/browse/JDK-8119169 , especially the comment about variable width disclosure node.
|
@Ziad-Mid This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
. |
Changed default disclosure width to 20 to fix the misalignment of items when having children in some of the treeitems
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1715/head:pull/1715$ git checkout pull/1715Update a local copy of the PR:
$ git checkout pull/1715$ git pull https://git.openjdk.org/jfx.git pull/1715/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1715View PR using the GUI difftool:
$ git pr show -t 1715Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1715.diff