Skip to content

8340344: The first item in TreeView is not aligned in the beginning #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

8340344: The first item in TreeView is not aligned in the beginning #1715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e6204
Fixed default disclosure width
Ziad-Mid Feb 19, 2025
e49c6e0
Merge branch 'openjdk:master' into 8340344.TreeViewAlign
Ziad-Mid Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public final DoubleProperty indentProperty() {
boolean disclosureVisible = disclosureNode != null && treeItem != null && ! treeItem.isLeaf();

final double defaultDisclosureWidth = maxDisclosureWidthMap.containsKey(tree) ?
maxDisclosureWidthMap.get(tree) : 18; // JDK-8119169: default width of default disclosure node
maxDisclosureWidthMap.get(tree) : 20; // JDK-8119169: default width of default disclosure node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not a good solution: I think the root cause is not in that the default value is incorrect, but in that two different values are used in the same view (i.e. that it first uses the default value, then the value computed from the disclosure node, if I read the code correctly).

Could you please investigate?

I've linked the JBS ticket mentioned in the comment, take a look at the discussion there https://bugs.openjdk.org/browse/JDK-8119169 , especially the comment about variable width disclosure node.

double disclosureWidth = defaultDisclosureWidth;

if (disclosureVisible) {
Expand Down